This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Enable incremental room kapt processing #7629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How stable is it? Looking at their issue tracker (https://issuetracker.google.com/issues/160042657, https://issuetracker.google.com/issues/159501719) it seems like people run into some issues here and there. Did you see any locally? |
|
Also, I'd love to see a before/after build scans for this. Can you share links for them? |
|
I haven't seen local problems yet, we can always remove this flag per-module if we run into problems. I'll send the HTML files to you on Slack since I can't attach them on Github. Here's the relevant numbers:
|
grigoryk
approved these changes
Jul 14, 2020
|
bors r+ |
|
Timed out. |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jul 20, 2020
7578: Closes #6460: Upstream RunWhenReadyQueue r=grigoryk a=NotWoods 7629: Enable incremental room kapt processing r=grigoryk a=NotWoods This saves us nearly 6 minutes in the artifact transformations stage. 7780: Expose l10n strings by default (fix #7777) r=Amejia481 a=Pike Use a wild card pattern to find localizable strings. If you're having WIP strings, put them into another file that's not name `strings.xml`. 7781: Trim whitespace from email & call context share r=Amejia481 a=sblatz Co-authored-by: Tiger Oakes <toakes@mozilla.com> Co-authored-by: Axel Hecht <axel@pike.org> Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves us nearly 6 minutes in the artifact transformations stage.