This repository was archived by the owner on Nov 1, 2022. It is now read-only.
samples-browser: Use SearchEngine from BrowserStore instead of SearchEngineManager. #8680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I totally forgot the tests. 😅 Will update those tomorrow. |
csadilek
approved these changes
Oct 13, 2020
👍 Filed #8686 and will add it to the code. |
pocmo
force-pushed
the
sample-browser-search
branch
from
c568e1c to
b5f285d
Compare
…wserStore instead of SearchEngineManager. This migrates sample-browser to stop using SearchEngineManager. For that I hide the provider of the default search engine behind an interface. This is a temporary solution until we have all apps using the SearchEngine from BrowserStore. After that we can get rid of that and make all our components use BrowserStore directly. I tested this in Fenix too and have a matching patch locally. Once this lands we should be able to migrate Reference Browser too.
pocmo
force-pushed
the
sample-browser-search
branch
from
b5f285d to
a037a2d
Compare
pocmo
added
🛬 needs landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates samples-browser to stop using SearchEngineManager. For that I hide the provider of the default search engine behind an interface. This is a temporary solution until we have all apps using the SearchEngine from BrowserStore. After that we can get rid of that and make all our components use BrowserStore directly.
I tested this in Fenix too and have a matching patch locally. Once this lands we should be able to migrate Reference Browser too.