This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Closes #9017: Memory leak in consumeFlow #9019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in #9017 and in source comments below. :)
TL;DR: It's possible for the owning view/fragment to be destroyed before the flow is produced (this happens async on another coroutine). We would then create a subscription and never unsubscribe because
onDestroyalready happened, leaking the subscription and owner.Alternatively, I've tried checking
owner.lifecycle.currentStatedirectly inchannelFlowbut that doesn't work reliably whereas this does.STR in Fenix:
Open new private tab
Switch to regular tab
Switch back to private mode