This repository was archived by the owner on Jun 17, 2024. It is now read-only.
Bug 1812247 - Increase tap area for history item's delete button#1122
Merged
mergify[bot] merged 2 commits intomozilla-mobile:mainfrom Mar 7, 2023
Merged
Conversation
For having the minimum of target size for x buttons from history page, it was added extra padding for devices with Android 9 or older. IncreaseTapArea was not used because it didn't work for these android versions.
Contributor
|
bors try |
tryBuild succeeded: |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For having the minimum of target size for x buttons from history page, it was added extra padding for devices with Android 9 or older. IncreaseTapArea was not used because it didn't work for these android versions.
Resolved:

Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1812247