Skip to content
This repository was archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1812247 - Increase tap area for history item's delete button#1122

Merged
mergify[bot] merged 2 commits intomozilla-mobile:mainfrom
RebecaTudor:increase-tap-area-for-delete-button
Mar 7, 2023
Merged

Bug 1812247 - Increase tap area for history item's delete button#1122
mergify[bot] merged 2 commits intomozilla-mobile:mainfrom
RebecaTudor:increase-tap-area-for-delete-button

Conversation

@RebecaTudor
Copy link
Contributor

@RebecaTudor RebecaTudor commented Mar 6, 2023

For having the minimum of target size for x buttons from history page, it was added extra padding for devices with Android 9 or older. IncreaseTapArea was not used because it didn't work for these android versions.

Resolved:
after

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1812247

For having the minimum of target size for x buttons from history page, it was
added extra padding for devices with Android 9 or older.
IncreaseTapArea was not used because it didn't work for these android versions.
@Mugurell
Copy link
Contributor

Mugurell commented Mar 7, 2023

bors try

bors bot pushed a commit that referenced this pull request Mar 7, 2023
@bors
Copy link

bors bot commented Mar 7, 2023

try

Build succeeded:

Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Mugurell Mugurell added the 🛬 needs landing PRs that are ready to land label Mar 7, 2023
@mergify mergify bot merged commit a5e43f0 into mozilla-mobile:main Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🛬 needs landing PRs that are ready to land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants