Skip to content
This repository was archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1844386 - Only use splash screen animation for SDK 31+#2928

Merged
mergify[bot] merged 2 commits intomozilla-mobile:mainfrom
mavduevskiy:bug-1844386
Jul 20, 2023
Merged

Bug 1844386 - Only use splash screen animation for SDK 31+#2928
mergify[bot] merged 2 commits intomozilla-mobile:mainfrom
mavduevskiy:bug-1844386

Conversation

@mavduevskiy
Copy link
Contributor

@mavduevskiy mavduevskiy commented Jul 20, 2023

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1844386

@mavduevskiy mavduevskiy added the work in progress Not ready to land yet. Work in progress (WIP). label Jul 20, 2023
@github-actions
Copy link
Contributor

🚧 Commit message is using the wrong format: draft

The comment message should look like:

    Bug xxxx - Short description of your change
    Optionally, a longer description of the change.

@github-actions
Copy link
Contributor

🚧 Pull request title is using the wrong format: draft

The pull request title should look like:

  Bug xxxx - Short description of your change

@mavduevskiy mavduevskiy changed the title draft Bug 1844386 - Only use splash screen animation for SDK 31+ Jul 20, 2023
@mavduevskiy mavduevskiy marked this pull request as ready for review July 20, 2023 15:38
@mavduevskiy mavduevskiy requested a review from rocketsroger July 20, 2023 15:38
@github-actions github-actions bot added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels Jul 20, 2023
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Tested on SDK 21, 23, 24, 28, 31 and 33 and all behave as expected.

@rocketsroger rocketsroger added 🛬 needs landing PRs that are ready to land approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jul 20, 2023
@mergify mergify bot merged commit 345e767 into mozilla-mobile:main Jul 20, 2023
@rocketsroger
Copy link
Contributor

@Mergifyio backport releases_v116

@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2023

backport releases_v116

✅ Backports have been created

Details

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved PR that has been approved 🛬 needs landing PRs that are ready to land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants