Skip to content
This repository was archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1823492 - Add timespan metric for Adjust attribution#2974

Merged
mergify[bot] merged 2 commits into
mozilla-mobile:mainfrom
rocketsroger:Bug1823492
Jul 25, 2023
Merged

Bug 1823492 - Add timespan metric for Adjust attribution#2974
mergify[bot] merged 2 commits into
mozilla-mobile:mainfrom
rocketsroger:Bug1823492

Conversation

@rocketsroger
Copy link
Copy Markdown
Contributor

@rocketsroger rocketsroger commented Jul 24, 2023

There was some questions related to Adjust attribution time. This is to use a timespan telemetry to confirm the data that we have from the time distribution telemetry.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1823492

@rocketsroger rocketsroger added 🕵️‍♀️ needs review PRs that need to be reviewed 🕵️‍♂️ needs data-review PRs that need to be data-reviewed labels Jul 24, 2023
@rocketsroger rocketsroger requested a review from a team July 24, 2023 18:46
@rocketsroger
Copy link
Copy Markdown
Contributor Author

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • This data will give us more information on Adjust attribution timing.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This will allow us to know more about attribution based behaviour.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
Adjust attribution timespan Category 1 - Technical data https://bugzilla.mozilla.org/show_bug.cgi?id=1823492
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • N/A, collection set to end or be renewed by version 124.
  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean and Glam.

  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Glam, and with mobile teams.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

@eliserichards
Copy link
Copy Markdown

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* This data will give us more information on Adjust attribution timing.


2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* This will allow us to know more about attribution based behaviour.


3. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* There are no other alternatives.


4. Can current instrumentation answer these questions?


* No.


5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
Adjust attribution timespan Category 1 - Technical data https://bugzilla.mozilla.org/show_bug.cgi?id=1823492

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* [https://dictionary.telemetry.mozilla.org/apps/fenix
  ](https://dictionary.telemetry.mozilla.org/apps/fenix%E2%80%A8)


7. How long will this data be collected? Choose one of the following:


* N/A, collection set to end or be renewed by version 124.


8. What populations will you measure?


* All channels, all locales, all countries


9. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


10. Please provide a general description of how you will analyze this data.


* Glean and Glam.


11. Where do you intend to share the results of your analysis?


* Only on Glean, Glam, and with mobile teams.


12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No third-party tools.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
  1. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.
  • Yes, through the "Send Usage Data" preference in the application settings.
  1. If the request is for permanent data collection, is there someone who will monitor the data over time?
  • This data will be collected until v124 with the option to renew/remove at that time.
  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
  • Category 1 - technical data.
  1. Is the data collection request for default-on or default-off?
  • Default on.
  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
  • No.
  1. Is the data collection covered by the existing Firefox privacy notice? If unsure: escalate to legal if:
  • Yes.
  1. Does the data collection use a third-party collection tool? If yes, escalate to legal.
  • No.

Result

data-review+

@eliserichards eliserichards removed the 🕵️‍♂️ needs data-review PRs that need to be data-reviewed label Jul 24, 2023
@rocketsroger rocketsroger reopened this Jul 24, 2023
@rocketsroger rocketsroger reopened this Jul 24, 2023
@github-actions github-actions Bot added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jul 24, 2023
@rocketsroger rocketsroger added the 🛬 needs landing PRs that are ready to land label Jul 24, 2023
@mergify mergify Bot merged commit 385295d into mozilla-mobile:main Jul 25, 2023
@rocketsroger
Copy link
Copy Markdown
Contributor Author

@Mergifyio backport releases_v116

@rocketsroger rocketsroger deleted the Bug1823492 branch July 25, 2023 05:55
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 25, 2023

backport releases_v116

✅ Backports have been created

Details

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved PR that has been approved 🛬 needs landing PRs that are ready to land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants