Closes #434: Make reference browser testable with Raptor/tp6#460
Merged
Conversation
csadilek
changed the title
Contributor
Author
|
Work (or rather more tests) in progress. |
csadilek
changed the title
Contributor
Author
|
Unblocking this as it's ready to land. I tested both speedometer and page load tests with Raptor. Also made sure we can still process customtab and share intents. The |
pocmo
approved these changes
Jan 23, 2019
pocmo
approved these changes
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just introduces an Activity for Raptor to launch. We'll save the
extrasprovided in the intent in a test configuration (similar to ourBuildConfig) and pass it along to theGeckoRuntimeSettings.There are small changes/enhancements needed in Raptor for this to work, but this PR is not blocked on them.
Using a separate Activity puts this out of the main execution path and allows us to land this on master. A separate branch wouldn't be practical as we want to run Raptor tests against latest changes and permanently having to keep a testing branch up-to-date isn't ideal. So, keeping the required code here as minimal as possible.