This repository was archived by the owner on Feb 26, 2022. It is now read-only.
Adjust release behavior in balrogscript. - #25
Merged
Conversation
rail
reviewed
Nov 24, 2017
| raise NotImplementedError("This logic piece has yet to be implemented") | ||
| log.info("Taskcluster Release style Balrog submission") | ||
|
|
||
| complete_info = e['completeInfo'] |
Contributor
There was a problem hiding this comment.
I'm not sure if we always submit completes. I'd make them optional as well. Just add a check to make sure that either of them is set, aka any([complete_info, partial_info]).
Contributor
Author
There was a problem hiding this comment.
added 3 commits
December 13, 2017 17:42
escapewindow
approved these changes
Dec 14, 2017
Contributor
There was a problem hiding this comment.
Awesome! Need some help in not regressing coverage?
Also, this was a big piece that I was worried about - wonderful to see this wasn't too complicated. @MihaiTabara ++ @rail ++ and @mozbhearsum ++
| - Support for processing release manifest from beetmover | ||
|
|
||
| ### Fixed | ||
| - fixed logging to prevent |
Contributor
There was a problem hiding this comment.
Incomplete changelog line? prevent what?
| 0 | ||
| ], | ||
| "version_string": "0.1.1" | ||
| "version_string": "0.2.0" |
Contributor
There was a problem hiding this comment.
Changelog says 2.0.0 :)
We should be at least 1.0.0 by now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.