ci(push-image): don't set TASKCLUSTER_ROOT_URL in task env#1315
Merged
ahal merged 1 commit intomozilla-releng:masterfrom Dec 16, 2025
Merged
ci(push-image): don't set TASKCLUSTER_ROOT_URL in task env#1315ahal merged 1 commit intomozilla-releng:masterfrom
ahal merged 1 commit intomozilla-releng:masterfrom
Conversation
abhishekmadan30
approved these changes
Dec 16, 2025
Contributor
|
Is this because it wasn't necessary, or because it was causing a problem? |
Contributor
|
@bhearsum it was causing failures after the switch from docker-worker to d2g pools, because while docker-worker overrides this env variable from the payload (among others: https://github.com/taskcluster/taskcluster/blob/62dc77f1f9116a28d662c08b788575a97d75217e/workers/docker-worker/src/task.js#L352-L368), with d2g we'd get the bogus value and fetch-content would fail with e.g.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.