-
Notifications
You must be signed in to change notification settings - Fork 6
Issue #37: VAPID validation front-end #67
Conversation
|
Some |
| 'css/main.css', | ||
| 'css/layout.css', | ||
| 'css/forms.css', | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra lines here 😐
bdfeaa7 to
b57de7f
Compare
|
|
||
| {% block content %} | ||
| {% if not request.user.is_authenticated %} | ||
| {% include 'dashboard/includes/authenticate.html' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than include the authenticate template at this URL, we should wrap the views in login_required to bounce the user to the login page and bring them back here. Can be filed as a follow-up issue/TODO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wanted to use that approach instead. I was having trouble implementing it, but I'll give it another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't burn yourself with too much time on it; happy to file an issue for next PR/merge/deploy.
|
Looking good. We should also make the |
|
Cool, with flake8 fixes and re-centering of the new iframe, I'm happy to merge this if we file the rest as follow-up issues. |
b57de7f to
77ae4b1
Compare
Done. I'll file a follow-up for the |
Issue #37: VAPID validation front-end
No description provided.