This repository was archived by the owner on Nov 14, 2018. It is now read-only.
Fix #73: Add basic 404 page #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openjck
force-pushed
the
issue-73-basic-404-page
branch
from
7f87767 to
25e51be
Compare
Collaborator
|
Cool. This should go nicely with the |
| {% extends "dashboard/base.html" %} | ||
|
|
||
| {% block content %} | ||
| <h2>Not Found</h2> |
Collaborator
There was a problem hiding this comment.
Kinda nit-picky, but can we include "404" here too? I find sometimes I inspect page responses when they say not found to see if it's an actual 404, or if there's some other logic going on.
Contributor
Author
|
Superseded by #83 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.