Should dockerflow heartbeat fail on warnings?

[groovecoder]

While using dockerflow, the __heartbeat__ view fails if any checks throw a message of checks.messages.WARNING or higher. Should it fail on WARNINGs, or only fail on ERROR or CRITICAL messages?

[jezdez]

I think this code was ported from Django's system checks, can you check if this is true there as well?

[groovecoder]

The BaseCommand check method has a fail_level=checks.ERROR parameter default:

https://github.com/django/django/blob/c60524c658f197f645b638f9bcc553103bfe2630/django/core/management/base.py#L406-L414

[groovecoder]

The only way to override the fail_level=checks.ERROR default is with a command-line argument to a management command, or configuring a custom fail_level in an app registry.

[jezdez]

Yeah, I think we should just update

python-dockerflow/src/dockerflow/django/views.py

Line 60 in d7fadb7

if level < checks.messages.WARNING:

to use checks.messages.ERROR. Also, since the Flask and Sanic integration has similar things, we need to be consistent and update it there, too.

[groovecoder]

Submitted #49