Merged
Conversation
While developing a new test, it did not fail even though no job was created. I realized thast the check_job function was not asserting that it checked anything, only that if it found something to check, that it was correct. This adds a check that it did find one, and only one, thing to check. Fortunately all tests were working and adding this check did not cause any failures.
This comment was marked as resolved.
This comment was marked as resolved.
tomrittervg
force-pushed
the
2022-05-13-fuzzy-path
branch
from
3062f85 to
53b7d91
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
We relied on undefined behavior by not being prefix-free when defining command lookups. That is to say you could have two commands './mach vendor foo' and './mach vendor' and the only thing that routed './mach vendor foo banana' to the first one was that it was found first when iterating through the dict keys. But that ordering is undefined behavior and it finally caught up with us and started causing intermittent failures. So switch it to an OrderedDict, so it is defined behavior.
Collaborator
Author
|
Okay, debugged the intermittent failure and attached another commit for it. |
bayounetta
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.