style(content): #3745 Add per-platform css files#3784
style(content): #3745 Add per-platform css files#3784k88hudson merged 1 commit intomozilla:masterfrom
Conversation
| content/vendor/react-redux.js (./vendor/react-redux.js) | ||
| content/data/ (./data/*) | ||
| #ifdef XP_MACOSX | ||
| content/data/content/activity-stream.css (./data/content/activity-stream-mac.css) |
There was a problem hiding this comment.
The content/data/ (./data/*) line is going to package all of them, so most likely leading to unreferenced file test failure. Do we make a new "top level" directory outside of data? css/ ?
There was a problem hiding this comment.
I suppose you can create a new directory in this PR, and I'll update it in #3755 if we don't want to put css in prerendered/static/activity-stream-mac.css.
Alternatively, the only thing inside data/ will be data/content/ after I remove locales.json from the other PR #3755. So we could have a data/css/*.css that we jar.mn package appropriately… and now that only activity-stream.bundle.js is the only single file:
content/data/content/activity-stream.bundle.js (./data/content/activity-stream.bundle.js)
content/data/content/assets/ (./data/content/assets/*)
content/data/content/tippytop/ (./data/content/tippytop/*)
#ifdef …
content/data/content/activity-stream.css (./data/css/activity-stream-mac.css)
And I suppose with that change, I could move prerendered to data/prerendered/.
(I suppose we could move things "up" a directory, i.e., ./data/{activity-stream.bundle.js,assets,css,tippytop,prerendered} if we're going to CLOBBER anyway although history might be broken. Separately, we could expose the resource://activity-stream/data/content/* as just resource://activity-stream/content/*…)
There was a problem hiding this comment.
On a related note, should I be updating #3775 (wow #3775 = package all locales vs #3755 = remove locales.json) and the related mozreview patch to use resource://activity-stream/data/content/prerendered/locales/en-US instead of resource://activity-stream/prerendered/locales/en-US ? if we move things to ./data/prerendered ?
There was a problem hiding this comment.
I like the idea of moving stuff to top-level directories (content/data/content was kind of weird anyway)
| @@ -0,0 +1,7 @@ | |||
| /* This is the windows variant */ | |||
There was a problem hiding this comment.
Just to be explicit, this comment block will appear in the generated file. Which I suppose would be handy for debugging?
There was a problem hiding this comment.
Yep, that's the idea
|
|
||
| // Search border should only have a 1-pixel blue border, so no box-shadow is needed. | ||
| .search-wrapper input:focus { | ||
| box-shadow: none; |
There was a problem hiding this comment.
The change from #3785 removes the border, so we'll have to fix this a different way.
|
Ok, I moved everything to a |
Mardak
left a comment
Mardak
left a comment
There was a problem hiding this comment.
Looks fine. I guess I'll keep the generated prerendered files at system-addon/prerendered/ like the now system-addon/css/
Includes a windows-specific search focus border style
3 participants
Includes a windows-specific search focus border style