This repository was archived by the owner on Feb 29, 2020. It is now read-only.
style(search): #3679 Fix search hover border styles#3785
Merged
k88hudson merged 1 commit intomozilla:masterfrom Nov 2, 2017
Merged
style(search): #3679 Fix search hover border styles#3785k88hudson merged 1 commit intomozilla:masterfrom
k88hudson merged 1 commit intomozilla:masterfrom
Conversation
Mardak
approved these changes
Nov 1, 2017
Member
Mardak
left a comment
Mardak
left a comment
There was a problem hiding this comment.
Looks good! Although… there's a slight unhovered color at the corner of the button now!! ;) :p
before/after:
| top: 0; | ||
| offset-inline-start: 0; | ||
| width: 100%; | ||
| height: 100%; |
Member
There was a problem hiding this comment.
nit: Might as well just do top/right/bottom/left:0 in case it seems like this is rtl-special.
| offset-inline-start: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| border-radius: 0 $border-radius $border-radius 0; |
Member
There was a problem hiding this comment.
nit: Let's share this inside .search-button (?) as a variable
Member
There was a problem hiding this comment.
Or.. if we have a slightly smaller radius, will the whites in the corner be filled in? !
Contributor
Author
|
Ok, I thought of a better way to do this that would prevent the gap and is slightly less hacky (basically changing the border/box-shadow combo to box-shadow only) |
k88hudson
force-pushed
the
gh3679
branch
2 times, most recently
from
afe1fca to
af79d7c
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3679. This patch makes the border a consistent color when hovering over the submit button, and adds a slightly darker border color when hovering over the input.