Skip to content
This repository was archived by the owner on Feb 29, 2020. It is now read-only.

Fix Bug 1421422 - Collect "region" and "profile_creation_date" for AS#3877

Merged
ncloudioj merged 1 commit intomozilla:masterfrom
ncloudioj:gh3876
Jan 12, 2018
Merged

Fix Bug 1421422 - Collect "region" and "profile_creation_date" for AS#3877
ncloudioj merged 1 commit intomozilla:masterfrom
ncloudioj:gh3876

Conversation

@ncloudioj
Copy link
Copy Markdown
Member

This closes #3876

@ncloudioj
Copy link
Copy Markdown
Member Author

@fmarier This only contains the document update for the change, I've already merged the patch before the data review (oops). We can further tweak the code patch if we find anything here.

Thanks!

@fmarier
Copy link
Copy Markdown

fmarier commented Nov 23, 2017

I've started an email thread with Marshall. Given Thanksgiving in the US, it may be a little while before I can respond.

@ncloudioj
Copy link
Copy Markdown
Member Author

@fmarier Thanks!

Just notice you've being also involved in this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1419788 , hope that's easier for you to get more context on this.

@fmarier
Copy link
Copy Markdown

fmarier commented Nov 27, 2017

How is the search region determined? Is it based on IP address geolocation? Do we set it to the exact country code or do we filter / group countries in any way?

The reason I'm asking is to figure out whether or not it can be considered Category 1.

@ncloudioj
Copy link
Copy Markdown
Member Author

@fmarier Not sure how exactly it's determined, I guess the Search team knows more detail about that. AS simply records the current value (as of the telemetry gets generated in Firefox) of pref "browser.search.region", which is exactly the same as what we have collected in https://bugzilla.mozilla.org/show_bug.cgi?id=1419788. So I suppose this should be of the same Category as the one in bug1419788.

@fmarier
Copy link
Copy Markdown

fmarier commented Nov 27, 2017

Thanks, I pinged Javaun about it.

@ncloudioj
Copy link
Copy Markdown
Member Author

Hey @fmarier, any updates on this? If you have any other questions, feel free to reach out :)

@fmarier
Copy link
Copy Markdown

fmarier commented Nov 29, 2017

I'm still trying to find someone who can answer my questions about the search country. Haven't had any luck yet.

@ncloudioj
Copy link
Copy Markdown
Member Author

@fmarier I think :mconnor can answer that question. Could you try reaching out to him please?

@fmarier
Copy link
Copy Markdown

fmarier commented Dec 1, 2017

Based on an email thread with mconnor, I have escalated this to @rjweiss and Marshall. @rjweiss will follow up with you once they have found a solution.

@fmarier fmarier removed their request for review December 1, 2017 18:29
@fmarier fmarier removed their assignment Dec 1, 2017
@ncloudioj
Copy link
Copy Markdown
Member Author

@fmarier Thanks for the update!

@Mardak Mardak changed the title chore(doc): Update telemetry document for region and profile_creation_date Fix Bug 1421422 - Collect "region" and "profile_creation_date" for AS Dec 1, 2017
@ncloudioj
Copy link
Copy Markdown
Member Author

  1. What questions will you answer with this data?
  • profile_creation_date: to understand the age of Activity Stream users' profile, which allows us to identify the new users and existing users among different Firefox versions.
  • region: to investigate certain geo related issues, for instance, the top stories feature was disabled if the region was unset or unknown.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
    This helps us understand if current user regions are set correctly, which improves the overall quality of recommendation content in Activity Stream.

  2. What alternative methods did you consider to answer these questions? Why were they not sufficient?
    There is no current instrumentation of this important value.

  3. Can current instrumentation answer these questions?
    There is no current instrumentation of this important value.

  4. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.

  • profile_creation_date is of category 1
  • region is of category 2 data (information about where the user’s machine sits). It is most similar to locale, in that it is a vague geo preference that does not leak the user’s location. However the measurement of region is a different one from locale, and region is used in important features in Activity Stream like Top Stories.
  1. How long will this data be collected? Choose one of the following:
    Permanently.

  2. What populations will you measure?
    All Firefox channels, all countries ,all locales.

  3. Please provide a general description of how you will analyze this data.
    General reporting on Redash.

  4. Where do you intend to share the results of your analysis?
    This is shared over Mozilla LDAP via Redash.

@ncloudioj
Copy link
Copy Markdown
Member Author

Hey @rjweiss @fmarier , I've attached the data review form above, could you r? it, please?

@fmarier
Copy link
Copy Markdown

fmarier commented Dec 19, 2017

How granular is the region code? Is it the country code like the one we have for search?

@Mardak
Copy link
Copy Markdown
Member

Mardak commented Dec 19, 2017

The region code is the one from browser.search.region so the same value used for search.

@fmarier
Copy link
Copy Markdown

fmarier commented Dec 19, 2017

The region code is the one from browser.search.region so the same value used for search.

Ok thanks. I haven't heard back from Marshall yet. He was working on this part with the search team to see if we can filter the countries. Once that's been resolved, we can carry on with the data review.

@fmarier
Copy link
Copy Markdown

fmarier commented Dec 19, 2017

To be clear, there's nothing wrong with the creation date since that's definitely in category1/2 territory. If you wanted to land that quickly, we could split it off from the region code and land it separately.

@ncloudioj
Copy link
Copy Markdown
Member Author

Hey @fmarier, any updates from the legal for the region collection? This is one of the P1 features for the next AS release, and given the Firefox 59 code freeze will be happening in days, could you keep us posted so that we can decide what's next accordingly. Thanks!

@ncloudioj
Copy link
Copy Markdown
Member Author

Merge and close this as the data reviewed was already done at

https://bugzilla.mozilla.org/show_bug.cgi?id=1421422

@ncloudioj ncloudioj merged commit 6597eb5 into mozilla:master Jan 12, 2018
@ncloudioj ncloudioj deleted the gh3876 branch January 12, 2018 23:01
@as-pine-proxy
Copy link
Copy Markdown
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collect "region" and "profile_creation_date" for AS

4 participants