Fix Bug 1421422 - Collect "region" and "profile_creation_date" for AS#3877
Fix Bug 1421422 - Collect "region" and "profile_creation_date" for AS#3877ncloudioj merged 1 commit intomozilla:masterfrom
Conversation
|
@fmarier This only contains the document update for the change, I've already merged the patch before the data review (oops). We can further tweak the code patch if we find anything here. Thanks! |
|
I've started an email thread with Marshall. Given Thanksgiving in the US, it may be a little while before I can respond. |
|
@fmarier Thanks! Just notice you've being also involved in this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1419788 , hope that's easier for you to get more context on this. |
|
How is the search region determined? Is it based on IP address geolocation? Do we set it to the exact country code or do we filter / group countries in any way? The reason I'm asking is to figure out whether or not it can be considered Category 1. |
|
@fmarier Not sure how exactly it's determined, I guess the Search team knows more detail about that. AS simply records the current value (as of the telemetry gets generated in Firefox) of pref "browser.search.region", which is exactly the same as what we have collected in https://bugzilla.mozilla.org/show_bug.cgi?id=1419788. So I suppose this should be of the same Category as the one in bug1419788. |
|
Thanks, I pinged Javaun about it. |
|
Hey @fmarier, any updates on this? If you have any other questions, feel free to reach out :) |
|
I'm still trying to find someone who can answer my questions about the search country. Haven't had any luck yet. |
|
@fmarier I think :mconnor can answer that question. Could you try reaching out to him please? |
|
@fmarier Thanks for the update! |
|
|
How granular is the region code? Is it the country code like the one we have for search? |
|
The region code is the one from browser.search.region so the same value used for search. |
Ok thanks. I haven't heard back from Marshall yet. He was working on this part with the search team to see if we can filter the countries. Once that's been resolved, we can carry on with the data review. |
|
To be clear, there's nothing wrong with the creation date since that's definitely in category1/2 territory. If you wanted to land that quickly, we could split it off from the region code and land it separately. |
|
Hey @fmarier, any updates from the legal for the |
|
Merge and close this as the data reviewed was already done at |
This closes #3876