Skip to content
This repository was archived by the owner on Feb 26, 2022. It is now read-only.

Bug 922558: add PredicateContext to sdk/context-menu - #1266

Closed
petli wants to merge 6 commits into
mozilla:masterfrom
commonsmachinery:922558
Closed

Bug 922558: add PredicateContext to sdk/context-menu#1266
petli wants to merge 6 commits into
mozilla:masterfrom
commonsmachinery:922558

Conversation

@petli

@petli petli commented Oct 15, 2013

Copy link
Copy Markdown
Contributor

As noted over on https://bugzilla.mozilla.org/show_bug.cgi?id=922558, everything but documentType is implemented.

Comment thread lib/sdk/context-menu.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume mimetype, node.ownerDocument.contentType should be it, but check what that is when viewing images

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That made sense. For images, it's e.g. image/jpeg.

@petli

petli commented Nov 28, 2013

Copy link
Copy Markdown
Contributor Author

Comments addressed with two additional patches. I verified that this merges cleanly onto current master.

@petli

petli commented Dec 6, 2013

Copy link
Copy Markdown
Contributor Author

Please review last commit that moves error handling into selection.js. This turns out to be mostly correct behaviour, the DOM code just throws a slightly incorrect exception. See e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=746906

(I don't know why I didn't try to catch the exception the first time...)

@Mossop

Mossop commented Dec 6, 2013

Copy link
Copy Markdown
Member

Awesome thanks. Good work finding the spec for that behaviour too, I had missed it. Since there's a few intermediate commits here I've gone ahead and squashed the branch and landed this as 8f80dfc

@Mossop Mossop closed this Dec 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants