This repository was archived by the owner on Feb 26, 2022. It is now read-only.
Changes for tab modules: Bug 598981, Bug 601239, Bug 593908 - #31
Merged
30 commits merged intoNov 19, 2010
Merged
Conversation
…i10s compatible (still need to update docs & tests)
…s with more then one tab.
…hack that was firing window ready event when content of first tab is ready.
…nTab method to the window and tab list.
…cation changes in TabOpen handlers.
…dow` with an option `url`.
…e` event listener to an internal method call, since it has to be called before listeners are notified.
…g tab event names same for Tab instances and TabList's.
…ggested an adding missing semicolons.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not complete patch since tests and docs require update + some cleanup is required.
In any case it's good idea to start with a first round of review since changes are big and core functionality is in place already.