Fix star rating spacing change - #14345
Merged
Merged
Conversation
nothingrandom
requested review from
a team and
eviljeff
and removed request for
a team
July 24, 2026 14:03
Member
|
I can haz before/after screenshot |
Member
Author
@eviljeff Added to the description |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14345 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 269 269
Lines 10750 10750
Branches 3314 3314
=======================================
Hits 10550 10550
Misses 187 187
Partials 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eviljeff
approved these changes
Jul 24, 2026
eviljeff
left a comment
Member
There was a problem hiding this comment.
I've watched those gifs over and over and still can't really see what was wrong but 🤷♂️ r+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16313
Reverted a previous tweak made in #14270 to attempt to improve the jump on the user star review flow when changing the star rating given, as it had the opposite effect for a first time review
Before:

After (technically the same as before the before):
