Skip to content

Fix star rating spacing change - #14345

Merged
nothingrandom merged 1 commit into
masterfrom
fix-star-rating-spacing-change
Jul 27, 2026
Merged

Fix star rating spacing change#14345
nothingrandom merged 1 commit into
masterfrom
fix-star-rating-spacing-change

Conversation

@nothingrandom

@nothingrandom nothingrandom commented Jul 24, 2026

Copy link
Copy Markdown
Member

Fixes mozilla/addons#16313

Reverted a previous tweak made in #14270 to attempt to improve the jump on the user star review flow when changing the star rating given, as it had the opposite effect for a first time review

Before:
Image

After (technically the same as before the before):
output

@nothingrandom
nothingrandom requested review from a team and eviljeff and removed request for a team July 24, 2026 14:03
@eviljeff

Copy link
Copy Markdown
Member

I can haz before/after screenshot

@nothingrandom

Copy link
Copy Markdown
Member Author

I can haz before/after screenshot

@eviljeff Added to the description

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (e962080) to head (62dfaa2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14345   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         269      269           
  Lines       10750    10750           
  Branches     3314     3314           
=======================================
  Hits        10550    10550           
  Misses        187      187           
  Partials       13       13           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eviljeff eviljeff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've watched those gifs over and over and still can't really see what was wrong but 🤷‍♂️ r+

@nothingrandom
nothingrandom merged commit fa7f695 into master Jul 27, 2026
24 of 25 checks passed
@nothingrandom
nothingrandom deleted the fix-star-rating-spacing-change branch July 27, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: some corrections needed on ratings on Notice-text

2 participants