Conversation
|
looks like we have a failure in one of our ES tests: https://travis-ci.org/mozilla/addons-server/jobs/494221610#L1651 |
diox
left a comment
There was a problem hiding this comment.
Can you do it inside create_switch, create_flag and create_sample instead, flushing every time ?
For the record this is an interesting problem: waffle does flush itself in save(), but it does that on_commit, and inside tests the transaction hasn't been committed at that point... It wouldn't happen if we were only using their test utils but we had issues with those in the past.
|
I was initially confused why we didn't see the same problem with every test that had to manipulate a waffle switch but it's actually pretty rare* for us to actually create a switch (and then want to toggle it) rather than just using *13 times vs 106 |
* Update django-waffle from 0.14.0 to 0.15.1 * Flush waffle after changing their values in tests
This PR updates django-waffle from 0.14.0 to 0.15.1.
Changelog
0.15.1
0.15.0
Links