Conversation
I didn't just add it to the `delete_obsolete_addons` task to be able to run it independently whenever we want to (afaik obsolete add-ons are already hard deleted anyway). Fixes #12463
EnTeQuAk
force-pushed
the
12463-disable-opensearch
branch
from
651f0b1 to
f637a38
Compare
| }, | ||
| 'disable_opensearch_addons': { | ||
| # We're re-using the `delete_addons` method but don't allow for hard | ||
| # deletes |
There was a problem hiding this comment.
Why don't we allow for hard deletes? At some point in the next few months we will want to hard-delete all the opensearch addons we'll be soft deleting this time. (And any soft-deleted opensearch add-ons in the database currently).
There was a problem hiding this comment.
It might be me being overly cautious but we may want to hard delete them at some point but not in the immediate future and we'll soft-delete first. That's why I separated them, not sure the cautiousness is appropriate.
Happy to change that if you think it isn't.
There was a problem hiding this comment.
I understand why we don't want to hard-delete them now, but I don't understand why you explicitly don't want the --with_deleted option available, so they can be hard deleted in the future without a further patch.
|
I added the |
2 participants
I didn't just add it to the
delete_obsolete_addonstask to be able torun it independently whenever we want to (afaik obsolete add-ons are
already hard deleted anyway).
Fixes mozilla/addons#7005