Remove the need for a settings_local.py (bug 1050155)#196
Merged
magopian merged 1 commit intoSep 1, 2014
Merged
Conversation
Contributor
|
For a more readable diff, use https://github.com/mozilla/olympia/pull/196/files?w=1 |
magopian
changed the title
Contributor
There was a problem hiding this comment.
We don't need (anymore?) DEBUG set to False here?
Contributor
Author
There was a problem hiding this comment.
DEBUG is always set to False (by default) when running the tests in Django (cf https://docs.djangoproject.com/en/dev/topics/testing/overview/#other-test-conditions)
Contributor
|
Good job on updating the docs! 👍 |
magopian
force-pushed
the
1050155-remove-need-for-settings-local
branch
3 times, most recently
from
bec75f0 to
cfe5342
Compare
magopian
force-pushed
the
1050155-remove-need-for-settings-local
branch
from
cfe5342 to
a1e1c8c
Compare
Contributor
|
r+wc |
magopian
added a commit
that referenced
this pull request
Sep 1, 2014
…s-local Remove the need for a settings_local.py (bug 1050155)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes bug 1050155
This means that the
settings_local.pywon't be used automagically bymanage.pyanymore. If you want to use it, either:local_settings.py(imported, if it exists, by the newsettings.pyfile), and make sure that you change the first line to befrom settings import *(don't import fromlib/settings_base.pyor fromdefault.settingsdirectly, I'm not sure what would happen)DJANGO_SETTINGS_MODULE=settings_localor the--settings=settings_localparameter when you run commands.I've checked with @jasonthomas, this should be ok with his last changes (can you please give a look at this PR and confirm that it looks ok to you?)