Skip to content

Bump Node.js to 20.x#23139

Merged
diox merged 2 commits intomozilla:masterfrom
diox:node-20
Mar 6, 2025
Merged

Bump Node.js to 20.x#23139
diox merged 2 commits intomozilla:masterfrom
diox:node-20

Conversation

@diox
Copy link
Copy Markdown
Member

@diox diox commented Mar 5, 2025

@diox diox requested review from a team and KevinMind and removed request for a team March 5, 2025 15:52
@@ -1,2 +1,2 @@
deb https://deb.nodesource.com/node_18.x nodistro main
deb-src https://deb.nodesource.com/node_18.x nodistro main
deb https://deb.nodesource.com/node_20.x nodistro main
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the gpg key?

3.139 Err:4 http://deb.debian.org/debian bookworm-updates InRelease
3.139   Unknown error executing apt-key
3.206 Get:8 https://deb.nodesource.com/node_20.x nodistro/main amd64 Packages [10.6 kB]
3.758 Get:9 http://deb.debian.org/debian-security bookworm-security/main amd64 Packages [246 kB]
3.827 Reading package lists...
4.224 W: Skipping acquire of configured file 'main/source/Sources' as repository 'https://deb.nodesource.com/node_20.x nodistro InRelease' does not seem to provide it (sources.list entry misspelt?)
4.224 W: GPG error: http://deb.debian.org/debian bookworm-updates InRelease: Unknown error executing apt-key
4.224 E: The repository 'http://deb.debian.org/debian bookworm-updates InRelease' is not signed.
------
Dockerfile:73

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GPG key is correct, it looks like a problem with the docker image (and not linked to this PR in particular - it's failing on a debian repo). I'll see if we can work around it.

I'll also remove the deb-src for node as it's useless & not working properly

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per docker-library/python#837 (comment) this is an issue with the host running docker with that image. I am not seeing it locally or in our CI, were you seeing this on your machine ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try updating docker on your host maybe ? In any case that's not caused by this PR.

Copy link
Copy Markdown
Contributor

@KevinMind KevinMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kmeinhardt@Kevins-MacBook-Pro addons-server % make shell          
docker compose exec --user olympia web bash
olympia@6c0bd9f3d4cf:~$ node -v
v20.18.3

Node 20 running, build passing. npm tests passing.

@diox diox merged commit ab0d325 into mozilla:master Mar 6, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants