Add Slack notification to healthcheck#23162
Merged
Conversation
ad045c2 to
e0694ac
Compare
7de35b4 to
b2dad85
Compare
- Updated the health check workflow to generate health check output and message JSON files. - Introduced a new script, `health_check_blocks.py`, to format health check data for Slack notifications. - Modified `health_check.py` to support output file generation and improved error handling. - Added tests for the new health check block formatting functionality. - Updated the workflow to send notifications to Slack with health check results, excluding local environment notifications.
b2dad85 to
65e7fe1
Compare
diox
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15440
Description
health_check_blocks.py, to format health check data for Slack notifications.health_check.pyto support output file generation and improved error handling.Context
This enahnces the healthcheck to add slack notifications when there are failures and a notification if the workflow fails for any reason.
Testing
You can run the healtcheck locally, modifying monitors to get different results. set an
--outputproperty to save the file.Then you can execute the bash script line by line to se what the final payload to slack would look like..
Finallly you can execute the healthcheck via github actions on this branch
This PR introduces a temp failing monitor that should trigger a notifaction to the channel.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.