Fix broken tests following locales tweaks#23168
Merged
diox merged 4 commits intomozilla:masterfrom Mar 13, 2025
Merged
Conversation
eviljeff
requested changes
Mar 13, 2025
Member
eviljeff
left a comment
eviljeff
left a comment
There was a problem hiding this comment.
can we have the linting fix in this PR too? (run ruff format)
diox
force-pushed
the
fix-test-search-ranking-failure
branch
from
e02c239 to
e38228b
Compare
diox
changed the title
Member
Author
|
With the way the code was previously written it would warn for locales already removed, which is why the tests were broken. My changes in |
diox
commented
Mar 13, 2025
|
|
||
| @pytest.mark.parametrize('lang', settings.LANGUAGES_BIDI) | ||
| def test_bidi_language_in_amo_languages(lang): | ||
| """Make sure all bidi marked locales are in AMO_LANGUAGES too.""" |
Member
Author
There was a problem hiding this comment.
I'm removing this test because that's no longer true, some bidi locales are no longer enabled on the site
eviljeff
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for mozilla/addons#15433