Skip to content

test fix for TestGetAddonRecommendations#23170

Merged
eviljeff merged 2 commits intomozilla:masterfrom
eviljeff:15377-taar-removal-followup-fixing-tests
Mar 13, 2025
Merged

test fix for TestGetAddonRecommendations#23170
eviljeff merged 2 commits intomozilla:masterfrom
eviljeff:15377-taar-removal-followup-fixing-tests

Conversation

@eviljeff
Copy link
Copy Markdown
Member

@eviljeff eviljeff commented Mar 13, 2025

Follow-up for: mozilla/addons#15377

Description

Trivial test fix for the TAAR removal PR. Not identified at the time due to mozilla/addons#15444

Testing

n/a

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff requested review from a team and diox and removed request for a team March 13, 2025 13:53
@eviljeff eviljeff marked this pull request as ready for review March 13, 2025 13:54
@eviljeff eviljeff force-pushed the 15377-taar-removal-followup-fixing-tests branch from 0f5b7c9 to f9be4cd Compare March 13, 2025 15:06
@eviljeff eviljeff requested a review from diox March 13, 2025 15:53
@eviljeff
Copy link
Copy Markdown
Member Author

Added another commit that gets our tests back to green. Added to this PR because it's another connected fail from the TAAR removal, but in the weirdest way - we were mocking statsd in completely the wrong file for 3 years 🙃 - it always should have been olympia.devhub.utils rather than olympia.addons.utils.

@eviljeff eviljeff merged commit 1a9968d into mozilla:master Mar 13, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants