Skip to content

all appeals back to their original queues#23189

Merged
KevinMind merged 2 commits intomozilla:masterfrom
eviljeff:15439-appeals-to-different-cinder-queue
Mar 18, 2025
Merged

all appeals back to their original queues#23189
KevinMind merged 2 commits intomozilla:masterfrom
eviljeff:15439-appeals-to-different-cinder-queue

Conversation

@eviljeff
Copy link
Copy Markdown
Member

@eviljeff eviljeff commented Mar 18, 2025

Fixes: mozilla/addons#15439

Description

Removes the special handling for extension appeals, so rather than going into the escalations queue directly, they go back into the original queue for that entity (amo_listings) - which is how extension appeals originally worked, and non-extension appeals continued to work.

Context

I didn't entirely revert #22851 because there was some useful refactoring in there, and I wanted to leave open the possibility that we may want to target different queues for appeals again in the future.

Testing

  • (you need your Cinder API key defined)
  • report an extension for abuse (anything but policy violation in the addon/both)
  • make a decision on the extension in Cinder (amo dev listings)
  • play back the payload locally, so you have the ContentDecision instance and the email in django admin fake mail
  • use the appeal link in the fake mail to appeal
  • see the appeal job is in the amo dev listings queue, rather than escalations

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff requested review from a team and KevinMind and removed request for a team March 18, 2025 16:56
@eviljeff eviljeff marked this pull request as ready for review March 18, 2025 17:26
@KevinMind KevinMind merged commit a6cf656 into mozilla:master Mar 18, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Redirect appeals to jobs completed in Cinder to the correct queue

2 participants