Fix fake FxA user auth for local environments#24419
Merged
diox merged 1 commit intomozilla:masterfrom Feb 5, 2026
Merged
Conversation
Now that we allow multiple user profiles to exist with the same email, we attempt to find users by fxa_id first, so we need to set identity['uid'] in fake auth in order to log in with the right user, otherwise we end up creating a new duplicate.
eviljeff
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we allow multiple user profiles to exist with the same email, we attempt to find users by
fxa_idfirst, so we need to setidentity['uid']in fake auth in order to log in with the right user, otherwise we end up creating a new duplicate.Fixes mozilla/addons#16044