Skip to content

Also display authors links for existing blocklistsubmissions, not jus…#24481

Merged
diox merged 2 commits intomozilla:masterfrom
diox:authors-link-in-existing-block-admin-page
Feb 23, 2026
Merged

Also display authors links for existing blocklistsubmissions, not jus…#24481
diox merged 2 commits intomozilla:masterfrom
diox:authors-link-in-existing-block-admin-page

Conversation

@diox
Copy link
Member

@diox diox commented Feb 18, 2026

Fixes mozilla/addons#16019 (follow-up)

Context

df03284 added links to authors of add-ons in blocklist submission add page, but on the change page a different template is used as the versions being blocked are no longer editable, so we need some extra code to handle that path.

Testing

  • Add a blocklistsubmission for an add-on in the admin you should see the author(s) links
  • Once added, find the link to that blocklistsubmission object in the blocklistsubmission list in the admin (may need to change the filters if it has been published).
  • Follow that link to the change page: you should see the author(s) links

}

.form-row .readonly ul {
margin: 0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was redundant (see line 94)

}

form ul.guid_list {
form .form-row ul.guid_list {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by because I noticed while looking at this patch: this adds specificity so that we keep the margin and padding for the ul.guid_list. Otherwise it looks a bit wonky with 0 padding.

@diox diox marked this pull request as ready for review February 18, 2026 13:55
@diox diox requested a review from willdurand February 20, 2026 09:22
@diox diox merged commit 01a9591 into mozilla:master Feb 23, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: New blocklistsubmission summary page should show userids of the affected add-ons

2 participants