Record an ActivityLog when session anomalies are detected for a user#24486
Merged
diox merged 5 commits intomozilla:masterfrom Feb 25, 2026
Merged
Record an ActivityLog when session anomalies are detected for a user#24486diox merged 5 commits intomozilla:masterfrom
diox merged 5 commits intomozilla:masterfrom
Conversation
When authentication is used (login_required or SessionIDAuthentication are about to return a valid user) we check that several key HTTP headers in the request match what we had in the session. Any mismatch counts as an anomaly and is logged. The feature is behind a enable-session-anomaly-recording waffle switch.
diox
commented
Feb 19, 2026
Comment on lines
-157
to
-158
| We skip the cache in Zeus if someone has an AMOv3+ cookie, so varying on | ||
| Cookie at this level only hurts us. |
Member
Author
There was a problem hiding this comment.
Hasn't been true for a while...
diox
commented
Feb 19, 2026
Comment on lines
-25
to
-26
| If redirect=False then we return 401 instead of redirecting to the | ||
| login page. That's nice for ajax views. |
Member
Author
There was a problem hiding this comment.
redirect=False wasn't used.
willdurand
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When session authentication is used (
login_requiredorSessionIDAuthenticationare about to return a valid user) this checks that several key HTTP headers in the request match what we had in the session. Any mismatch we didn't already know about counts as an anomaly and is logged.The feature is behind a
enable-session-anomaly-recordingwaffle switch.Testing
These headers are added/overwritten by the CDN/WAF, but you can test locally by:
enable-session-anomaly-recordingwaffle switchClient-JA4,Cloudfront-Viewer-Country,Ohfp) setActivityLogfor that user showing the differences indetails. You should also see the same thing in the session under asession_anomalieskey.Fixes https://mozilla-hub.atlassian.net/browse/AMOENG-2165
Fixes https://mozilla-hub.atlassian.net/browse/AMOENG-2170