When installing deps, don't clean existing dir if only installing dev deps#24505
Merged
diox merged 1 commit intomozilla:masterfrom Feb 24, 2026
Merged
When installing deps, don't clean existing dir if only installing dev deps#24505diox merged 1 commit intomozilla:masterfrom
diox merged 1 commit intomozilla:masterfrom
Conversation
… deps In CI, when using the run-docker minimal action specifically, we're calling this script with just "dev" as the target, and don't want to remove existing deps, we're only installing dev ones. PRs were already bypassing that cleaning because they're using DOCKER_TAG=local, but branch builds set DOCKER_TAG corresponding to the commit being built. Everywhere else shouldn't be affected: development environment is always passing `pip, prod` as targets (and optionally dev when running development image), and the calls from Dockerfile will have DOCKER_TAG set to local.
willdurand
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CI, when using the run-docker minimal action specifically, we're calling this script with just "dev" as the target, and don't want to remove existing deps, we're only installing dev ones. PRs were already bypassing that cleaning because they're using
DOCKER_TAG=local, but branch builds setDOCKER_TAGcorresponding to the commit being built.Everywhere else shouldn't be affected: development environment is always passing
pip, prodas targets (and optionallydevwhen running development image), and the calls fromDockerfilewill haveDOCKER_TAGset tolocal.This should fix
master.