Fix mass-block of add-ons with at least one version already blocked#24569
Merged
diox merged 3 commits intomozilla:masterfrom Mar 5, 2026
Merged
Fix mass-block of add-ons with at least one version already blocked#24569diox merged 3 commits intomozilla:masterfrom
diox merged 3 commits intomozilla:masterfrom
Conversation
diox
force-pushed
the
mass-block-already-blocked-fix
branch
from
7a73676 to
c52142e
Compare
Mass-blocking (over GUID_FULL_LOAD_LIMIT add-ons) at once triggers the use of FakeBlockAddonVersion, but that doesn't have blockversion so it would fail when trying to determine the block type of an already blocked version.
diox
force-pushed
the
mass-block-already-blocked-fix
branch
from
c52142e to
2703f02
Compare
eviljeff
approved these changes
Mar 5, 2026
diox
added a commit
that referenced
this pull request
Mar 10, 2026
…24569) * Fix mass-block of add-ons with at least one version already blocked Mass-blocking (over GUID_FULL_LOAD_LIMIT add-ons) at once triggers the use of FakeBlockAddonVersion, but that doesn't have blockversion so it would fail when trying to determine the block type of an already blocked version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mass-blocking (over
GUID_FULL_LOAD_LIMITadd-ons) at once triggers the use ofFakeBlockAddonVersion, but that doesn't haveblockversionso it would fail when trying to determine the block type of an already blocked version.Fixes mozilla/addons#16105