Bump MySQL client (and server for local environments) to 8.4#24586
Merged
diox merged 1 commit intomozilla:masterfrom Mar 16, 2026
Merged
Bump MySQL client (and server for local environments) to 8.4#24586diox merged 1 commit intomozilla:masterfrom
diox merged 1 commit intomozilla:masterfrom
Conversation
We haven't switched to 8.4 in dev/stage/prod yet but mysqlclient should be backwards-compatible.
eviljeff
approved these changes
Mar 12, 2026
Member
eviljeff
left a comment
eviljeff
left a comment
There was a problem hiding this comment.
django seems to run, and ran some tests which access the database
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We haven't switched to 8.4 in dev/stage/prod yet but mysqlclient should be backwards-compatible.
Refs mozilla/addons#15918
Local environments
If you run into issues applying this on your local environment, read this:
mozilla/addons#15918 (comment)
In addition, going back to a previous version of the database requires resetting mysql data, which you can do through
make down && make docker_mysqld_volume_remove(downgrades while keeping data are not supported by MySQL). If you start using this patch and care about your local data, make a backup first and replay it after switching branches.