Skip to content

correct email for cases when add-on will not be public despite approval#24606

Merged
eviljeff merged 3 commits intomozilla:masterfrom
eviljeff:16058-update-appeal-success-template-after-content-review
Mar 17, 2026
Merged

correct email for cases when add-on will not be public despite approval#24606
eviljeff merged 3 commits intomozilla:masterfrom
eviljeff:16058-update-appeal-success-template-after-content-review

Conversation

@eviljeff
Copy link
Copy Markdown
Member

@eviljeff eviljeff commented Mar 16, 2026

Fixes: mozilla/addons#16058

Description

Adds support to emails for cases where the add-on is not public, despite Add-on|Version|Listing appeal/override.

Context

We previously always assumed that an appeal/override led to the add-on being public, but there are cases where that isn't true.

I ended up refactoring the tests to make it (a little) better to add coverage for these cases.

Testing

The new cases the emails now cover are:

  • Content is approved (after a previous content rejection), but the add-on isn't public because no listed versions are approved at the time (rejected, awaiting review, etc)
  • an appeal on a listing rejection but the add-on isn't public because no listed versions are approved at the time (rejected, awaiting review, etc)
  • an appeal on a force disable, but the add-on isn't public because no listed versions are approved at the time (rejected, awaiting review, etc)
  • an appeal on a version rejection, but the add-on isn't public because no listed versions are approved at the time, AND the version that was rejected was awaiting review rather than approved.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff marked this pull request as ready for review March 16, 2026 11:50
@eviljeff eviljeff requested a review from diox March 16, 2026 11:50
if hasattr(self.target, 'deleted')
else not self.target.banned
if hasattr(self.target, 'banned')
else getattr(self.target, 'status', None) == amo.STATUS_APPROVED
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to use is_public() instead of that last one, which handles the edge case of an add-on being set to invisible.

@eviljeff eviljeff merged commit 8e1d3ba into mozilla:master Mar 17, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: change wording for content approved addons with awaiting review state

2 participants