correct email for cases when add-on will not be public despite approval#24606
Merged
eviljeff merged 3 commits intomozilla:masterfrom Mar 17, 2026
Conversation
diox
approved these changes
Mar 16, 2026
src/olympia/abuse/actions.py
Outdated
| if hasattr(self.target, 'deleted') | ||
| else not self.target.banned | ||
| if hasattr(self.target, 'banned') | ||
| else getattr(self.target, 'status', None) == amo.STATUS_APPROVED |
Member
There was a problem hiding this comment.
Probably want to use is_public() instead of that last one, which handles the edge case of an add-on being set to invisible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#16058
Description
Adds support to emails for cases where the add-on is not public, despite Add-on|Version|Listing appeal/override.
Context
We previously always assumed that an appeal/override led to the add-on being public, but there are cases where that isn't true.
I ended up refactoring the tests to make it (a little) better to add coverage for these cases.
Testing
The new cases the emails now cover are:
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.