Additional confusables characters + deduping existing#24612
Merged
diox merged 7 commits intomozilla:masterfrom Mar 16, 2026
Merged
Additional confusables characters + deduping existing#24612diox merged 7 commits intomozilla:masterfrom
diox merged 7 commits intomozilla:masterfrom
Conversation
eviljeff
approved these changes
Mar 16, 2026
Member
eviljeff
left a comment
There was a problem hiding this comment.
Do you think it's feasible have a test that checks for duplication programmatically? Manually de-duping seems like an inefficient process.
Member
Author
|
I automated the deduping, so I'll look into add a test so that we don't accidentally add more dupes in the future yeah. I fear it might be a bit too slow though... |
Member
Author
|
I've added a script to check for dupes in a0fd570 but left it separate in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More confusable characters for our custom normalization, but also deduping the existing ones:
unicodedatanormalizationiandl.Testing
With the patch applied, you can check what we think a given character is confusable with by doing:
That allows spot-checking any characters you are having doubts for.