add tasks that submit new addons and changes for content review to cinder#24642
Merged
eviljeff merged 3 commits intomozilla:masterfrom Mar 24, 2026
Merged
Conversation
ef9b3c4 to
51ceb0e
Compare
Member
|
diox
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15969
Description
Adds tasks for submitting an add-on submission to Cinder for content review; and for content changes. Most of the work is in the Cinder entity classes that send an event to a workflow.
Context
See Cinder for the workflow. We will need to replicate this on Cinder prod before the tasks will work there (workflows can be exported and imported, afaik)
I'm in communication with the Cinder developers about what the queue job page displays, because currently the metadata we send is somewhat hidden away. If we have to make changes to what/how we send the event we can file a follow-up.
Testing
CINDER_API_TOKENis defined in local_settings)from olympia.abuse.tasks import submit_addon_for_content_reviewsubmit_addon_for_content_review(addon_pk=xxx)ActivityLog.objects.filter(action=208)). Again, this will be cleaner if the job doesn't already exist, so clean up any open job for an add-on with the same pk.from olympia.abuse.tasks import submit_addon_change_for_content_reviewsubmit_addon_change_for_content_review(activity_log_id=xxx)EDIT_ADDON_PROPERTYactivity.Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.