Skip to content

set override_of on new decision#24721

Merged
eviljeff merged 1 commit intomozilla:masterfrom
eviljeff:16171-fix-decision-overrides
Apr 10, 2026
Merged

set override_of on new decision#24721
eviljeff merged 1 commit intomozilla:masterfrom
eviljeff:16171-fix-decision-overrides

Conversation

@eviljeff
Copy link
Copy Markdown
Member

@eviljeff eviljeff commented Apr 9, 2026

Fixes: mozilla/addons#16171

Description

fixes regression from #24679 - we stopped setting override_of on new decisions, where the job already had a decision.

Context

Testing

  • create a decision on a job in Cinder and replay the payload
  • override that decision in Cinder and replay the payload
  • the correct email should be sent (that refers to an earlier decision

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff marked this pull request as ready for review April 9, 2026 15:28
@eviljeff eviljeff requested a review from diox April 9, 2026 16:46
@eviljeff eviljeff merged commit 428a28a into mozilla:master Apr 10, 2026
84 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: decision overrides from Cinder are broken

2 participants