Allow multiple BlocklistSubmission in parallel for the same version#24728
Merged
diox merged 5 commits intomozilla:masterfrom Apr 14, 2026
Merged
Allow multiple BlocklistSubmission in parallel for the same version#24728diox merged 5 commits intomozilla:masterfrom
diox merged 5 commits intomozilla:masterfrom
Conversation
Conflicts are resolved automatically when setting up the block depending on the BlocklistSubmission action: an ADDCHANGE action is never allowed to "downgrade" a block_type, only an expicit SOFTEN can do that. In addition, adding a delay on a SOFTEN action is disallowed.
eviljeff
approved these changes
Apr 13, 2026
Member
eviljeff
left a comment
eviljeff
left a comment
There was a problem hiding this comment.
In addition, adding a delay on a SOFTEN action is disallowed.
Do we need to enforce this elsewhere - e.g. in the models itself? BlocklistSubmissions can be created automatically now/soon.
Member
Author
I don't think it's necessary (famous last words). We should never have automation adding a delay with a soften action in the first place, softening is really meant to fix a situation were we were too harsh, I don't see a situation where we would want to automatically do that with a delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conflicts are resolved automatically when setting up the block depending on the BlocklistSubmission action: an ADDCHANGE action is never allowed to "downgrade" a block_type, only an expicit SOFTEN can do that. In addition, adding a delay on a SOFTEN action is disallowed.
Fixes mozilla/addons#16117