Unblock addon versions from follow-up actions on appeal#24799
Merged
eviljeff merged 1 commit intomozilla:masterfrom Apr 28, 2026
Merged
Unblock addon versions from follow-up actions on appeal#24799eviljeff merged 1 commit intomozilla:masterfrom
eviljeff merged 1 commit intomozilla:masterfrom
Conversation
14c44a4 to
7d4c4c1
Compare
diox
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#16119
Description
Adds appeal support for follow-up actions - which are (currently) delayed block actions. Blocked versions are unblocked; pending BlocklistSubmissions are deleted or amended.
Context
In this patch I added a
reverse_actionto the ContentActionDelayedXxxYyyBlockAddon classes, because I didn't like howContentActionTargetAppealApprove.process_actionwas getting longer and longer. The thinking was that we can delegate the reversal of an action to the class that executed it. If it seems like a good model we can rewrite the other actions to work the same way. Though it's not without it's problems - we often want different functionality (e.g. target_versions; emails) for an appeal that reverses an action compared to the initial action.Follow-up actions are always executed after a primary action. The filtering in the view prevents any of
AMO_FU_DELAY_XXX_YYY_BLOCK_ADDONdecision actions from being primary actions, but I've attempted to write the action class support so if it was executed as a primary action the appeal would still work.Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.