Always record Promoted Approval when approving add-on versions#24824
Merged
diox merged 2 commits intomozilla:masterfrom May 5, 2026
Merged
Always record Promoted Approval when approving add-on versions#24824diox merged 2 commits intomozilla:masterfrom
diox merged 2 commits intomozilla:masterfrom
Conversation
This allows the listed_pre_review and unlisted_pre_review flags to be flipped back and forth for promoted group without any negative consequences for the versions approved while they are off: they would still have their approval recorded, so they would still be considered approved for the promoted group if the flags are turned back on.
eviljeff
reviewed
May 5, 2026
eviljeff
approved these changes
May 5, 2026
eviljeff
reviewed
May 5, 2026
| # These addons shouldn't be be attempted for auto approval anyway, | ||
| # but double check that the cron job isn't trying to approve it. | ||
| assert not self.user.id == settings.TASK_USER_ID | ||
| if self.addon.promoted_groups(currently_approved=False): |
Member
There was a problem hiding this comment.
I can see you've already merged this, but
Suggested change
| if self.addon.promoted_groups(currently_approved=False): | |
| if group: |
Member
Author
There was a problem hiding this comment.
Doh missed this when reverting the previous part, I'll patch it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the
listed_pre_reviewandunlisted_pre_reviewflags to be flipped back and forth for promoted group without any negative consequences for the versions approved while they are off: they would still have their approval recorded, so they would still be considered approved for the promoted group if the flags are turned back on.Fixes mozilla/addons#16165