Add unlisted review page link to devhub and change review page links.#4932
Merged
eviljeff merged 2 commits intomozilla:masterfrom Mar 16, 2017
Merged
Conversation
diox
reviewed
Mar 15, 2017
| {% if unlisted and addon.has_listed_versions() %} | ||
| <li><a href="{{ url('editors.review', addon.slug) }}">{{ _('Listed Review Page') }}</a></li> | ||
| {# On the listed review page, show link to unlisted version review if necessary and allowed #} | ||
| {% elif action_allowed('Addons', 'ReviewUnlisted') and addon.has_unlisted_versions() %} |
Member
There was a problem hiding this comment.
Because it's a elif if you're on the unlisted page, and there are no listed versions, we can enter this block (provided the other conditions are met). In that case we'd show the unlisted review page link even though you're already on it. Worth changing to {% endif %}{% if not unlisted and ... or something similar ?
Member
Author
There was a problem hiding this comment.
either that or {% elif not unlisted and action_allowed('Addons', 'ReviewUnlisted') and addon.has_unlisted_versions() %}
diox
approved these changes
Mar 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes mozilla/addons#3965 and simplifies the logic on the review page so it works in more edge cases (e.g. accessing the listed review page when there aren't any listed versions)