Skip to content

Bug 1193137: Remove commit_manually decorator from app version update task. #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magopian merged 1 commit into from
Aug 12, 2015
Merged

Bug 1193137: Remove commit_manually decorator from app version update task. #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/addons/cron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ def update_addon_appsupport():
ids = (Addon.objects.valid().distinct()
.filter(newish, good).values_list('id', flat=True))

task_log.info('Updating appsupport for %d new-ish addons.' % len(ids))
ts = [_update_appsupport.subtask(args=[chunk])
for chunk in chunked(ids, 20)]
TaskSet(ts).apply_async()
Expand All @@ -270,9 +271,9 @@ def update_all_appsupport():


@task
@transaction.commit_manually
def _update_appsupport(ids, **kw):
from .tasks import update_appsupport
task_log.info('Updating appsupport for %d of new-ish addons.' % len(ids))
update_appsupport(ids)


Expand Down
1 change: 1 addition & 0 deletions apps/addons/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def update_last_updated(addon_id):
Addon.objects.filter(pk=pk).update(last_updated=t)


@write
def update_appsupport(ids):
log.info("[%s@None] Updating appsupport for %s." % (len(ids), ids))

Expand Down