sent password reset email even for getpersonas migrated accounts (bug 998477)#67
Merged
magopian merged 1 commit intomozilla:masterfrom May 7, 2014
Conversation
magopian
changed the title
magopian
changed the title
Contributor
There was a problem hiding this comment.
I wonder if we wanna go this way, or just put the "user mode switch" as a dependency of this one?
Contributor
There was a problem hiding this comment.
Do we need "is True" given that has_usable_pwd return a boolean?
Contributor
|
r+ |
magopian
added a commit
that referenced
this pull request
May 7, 2014
…sent sent password reset email even for getpersonas migrated accounts (bug 998477)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug 998477
At the moment, even if we can't reset a user's password (because her password
is empty), we still display a message stating that an email was sent to
reset it. This is now fixed.
Also, we have our own way of checking passwords, so the
AbstractBaseUser.has_usable_passwordchecks aren't loose enough for us (for example it checks thesettings.PASSWORD_HASHERSwhich we don't necessarily use). An exemple is for passwords for migrated getpersonas accounts which are b64encoded. We thus monkeypatch thishas_usable_password, waiting for PR #63 to be merged.@washort please check the
# TODOI added in this PR if yours (#63) is merged after this one.