Skip to content

Address security warnings in our GH actions #16357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diox merged 1 commit into from
Jul 27, 2026
Merged

Address security warnings in our GH actions #16357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/context/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,16 @@ runs:
run: |
# Stable check for if the workflow is running on the default branch
# https://stackoverflow.com/questions/64781462/github-actions-default-branch-variable
is_default_branch="${{ format('refs/heads/{0}', env.default_branch) == github.ref }}"
is_default_branch="${{ env.ref_name == env.default_branch }}"

# In most events, the epository refers to the head which would be the fork
# In most events, the repository refers to the head which would be the fork
is_fork="${{ github.event.repository.fork }}"
# Default version is the branch name
docker_version="${ref_name}"

# This is different in a pull_request where we need to check the head explicitly
if [[ "${{ github.event_name }}" == 'pull_request' ]]; then
# repository on a pull request refers to the base which is always mozilla/<repsotory>
# repository on a pull request refers to the base which is always mozilla/<repository>
is_head_fork="${{ github.event.pull_request.head.repo.fork }}"
# https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions
is_dependabot="${{ github.actor == 'dependabot[bot]' }}"
Expand Down
7 changes: 1 addition & 6 deletions .github/actions/slack-workflow-notification/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,7 @@ runs:
cat "${GITHUB_OUTPUT}"

- name: Notify Slack
# This action uses another action defined in the same repository.
# Github action does not support dynamic version selection so we have to pick
# a single version. Pinning to a commit hash is not a great idea because we have to
#manage multiple cascading version updates for the action and this file cannot reference
# it's own git hash.
uses: mozilla/addons/.github/actions/slack@main # zizmor: ignore[unpinned-uses]
uses: mozilla/addons/.github/actions/slack@43401a931ebc09f2e511deed766171b0105414bc
with:
slack_token: ${{ inputs.slack_token }}
method: chat.postMessage
Expand Down
Loading