Skip to content

Run taskgraph generation with Python 3#4394

Merged
skhamis merged 4 commits intomozilla:mainfrom
ahal:taskgraph_py3
Aug 23, 2021
Merged

Run taskgraph generation with Python 3#4394
skhamis merged 4 commits intomozilla:mainfrom
ahal:taskgraph_py3

Conversation

@ahal
Copy link
Copy Markdown
Member

@ahal ahal commented Aug 19, 2021

This fixes issue #4393.

We'd like to drop support for Python 2 in the taskgraph repo. To ensure the ability to address issues quickly, we'd like to first update consumers of it to Python 3.

@ahal ahal marked this pull request as draft August 19, 2021 18:10
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4394 (b0ed7d5) into main (94baebd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4394   +/-   ##
=======================================
  Coverage   76.00%   76.00%           
=======================================
  Files          46       46           
  Lines        4193     4193           
=======================================
  Hits         3187     3187           
  Misses       1006     1006           
Impacted Files Coverage Δ
components/nimbus/src/enrollment.rs 97.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94baebd...b0ed7d5. Read the comment docs.

@ahal ahal marked this pull request as ready for review August 19, 2021 19:44
Copy link
Copy Markdown
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have I have permission to do an official review here, but LGTM

@ahal ahal force-pushed the taskgraph_py3 branch 2 times, most recently from 9bb73be to 00862ca Compare August 20, 2021 13:57
@ahal
Copy link
Copy Markdown
Member Author

ahal commented Aug 20, 2021

Latest force push was just rebasing on main (CI passed prior to that)

@skhamis skhamis self-requested a review August 20, 2021 21:39
skhamis
skhamis previously approved these changes Aug 20, 2021
Copy link
Copy Markdown
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes -- LGTM!

@mergify mergify Bot dismissed skhamis’s stale review August 21, 2021 04:33

The pull request has been modified, dismissing previous reviews.

@ahal
Copy link
Copy Markdown
Member Author

ahal commented Aug 21, 2021

Thanks @skhamis ! I don't have permission to merge or apply labels, help merging would be appreciated. Also I rebased on top of latest main and apparently that invalidated your review (there weren't any code changes). Sorry about that.

@ahal ahal requested a review from skhamis August 23, 2021 13:35
@skhamis
Copy link
Copy Markdown
Contributor

skhamis commented Aug 23, 2021

No problem @ahal! Yeah I think we have new merging rules that remove review after a rebase -- I'll go ahead and merge it now.

@skhamis skhamis merged commit 6662a74 into mozilla:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants