Conversation
Codecov Report
@@ Coverage Diff @@
## main #4407 +/- ##
=======================================
Coverage 76.00% 76.00%
=======================================
Files 46 46
Lines 4193 4193
=======================================
Hits 3187 3187
Misses 1006 1006 Continue to review full report at Codecov.
|
|
Looks like taskcluster builds were failing https://firefox-ci-tc.services.mozilla.com/tasks/HrllhdAzSvqRA3Wr1DyIRw/runs/0/logs/public/logs/live.log I think it's because they were running in python2 instead of python3, the python interpreter couldn't recognize the The reason the builds didn't fail with #4394 (that introduced the python3 support) is because that PR didn't run |
There was a problem hiding this comment.
Makes sense and LGTM! Nice catch 🚀
Edit: FTR, I did try look at any other places we still might be using python2 and could only find
application-services/.circleci/config.yml
Line 106 in e1abe5a
Our CI for dependencies was failing on an
opensslsecurity vulnerability. We do not use openssl except for tests (it's pulled in byreqwest, which is pulled in byviaduct_reqwestthat is only ever used in tests)Ran cargo update to get the versions not affected, and get CI to pass.
ref on the vulnerabilities:
Here's ci failing: https://app.circleci.com/pipelines/github/mozilla/application-services/28022/workflows/0561703c-b69e-4985-ab91-d2d0f7d42f95/jobs/112849