Bug 2055621 - viaduct: only link to sqlite when the ohttp feature is enabled. - #7527
Merged
Merged
Conversation
…enabled. Bug 2054009 added a dependency from viaduct to rusqlite, which broke the nimbus-fml toolchain build because it doesn't have the x86_64-linux-musl-gcc compiler. viaduct doesn't actually need to link to sqlite outside the ohttp feature, so properly encode that in its Cargo.toml. Because nimbus-fml doesn't enable viaduct's ohttp feature, it won't try to link to sqlite anymore.
mhammond
approved these changes
Aug 6, 2026
jonesetc
pushed a commit
to jonesetc/application-services
that referenced
this pull request
Aug 12, 2026
…enabled. (mozilla#7527) Bug 2054009 added a dependency from viaduct to rusqlite, which broke the nimbus-fml toolchain build because it doesn't have the x86_64-linux-musl-gcc compiler. viaduct doesn't actually need to link to sqlite outside the ohttp feature, so properly encode that in its Cargo.toml. Because nimbus-fml doesn't enable viaduct's ohttp feature, it won't try to link to sqlite anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugzilla URL: https://bugzilla.mozilla.org/show_bug.cgi?id=2055621
Bug 2049856 added a dependency from viaduct to rusqlite, which broke the nimbus-fml toolchain build on the Firefox CI because it doesn't have the x86_64-linux-musl-gcc compiler.
viaduct doesn't actually need to link to sqlite outside the ohttp feature, so properly encode that in its Cargo.toml.
Because nimbus-fml doesn't enable viaduct's ohttp feature, it won't try to link to sqlite anymore.
Try run: https://treeherder.mozilla.org/jobs?repo=try&revision=ad6338a9be84fca240cc2b70b9bf1fbbb60ecda8
This change would break users that depend on viaduct without the ohttp feature and otherwise depend on ohttp with its external-sqlite feature but do not depend on rusqlite by any other means. I believe that's acceptable and doesn't need a changelog entry.
Change suggested by :glandium in https://phabricator.services.mozilla.com/D316132
Pull Request checklist
[ci full]to the PR title.