Fix Bug 952549 - Update ESR versions in the Firefox details#1549
Merged
jgmize merged 1 commit intomozilla:masterfrom Mar 27, 2014
kyoshino:update-esr-versions
Merged
Fix Bug 952549 - Update ESR versions in the Firefox details#1549jgmize merged 1 commit intomozilla:masterfrom kyoshino:update-esr-versions
jgmize merged 1 commit intomozilla:masterfrom
kyoshino:update-esr-versions
Conversation
bedrock/firefox/tests.py
Outdated
Contributor
There was a problem hiding this comment.
We should only be checking for the latest (24), not any ESR release (10,17,24)?
Contributor
Author
There was a problem hiding this comment.
Yes, looks like we have to update this manually along with the range above. Both 10 and 17 are now EOL, and the esr_major_versions mean the latest Firefox ESR versions as per context_processors.py.
Contributor
There was a problem hiding this comment.
The logic behind this is now being discussed over on Bug 952549.
Contributor
Author
|
Closing until the final decision is made in Bug 952549. |
Contributor
Author
|
Firefox 10 and 17 are totally obsolete. Let's do this and go ahead with #1548. |
jgmize
added a commit
that referenced
this pull request
Mar 27, 2014
Fix Bug 952549 - Update ESR versions in the Firefox details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
firefox_details.esr_major_versionsarray is used for version checks. It should be up-to-date.