Skip to content

CMS about us page#17099

Merged
wen-2018 merged 3 commits intomainfrom
cms-about
Apr 17, 2026
Merged

CMS about us page#17099
wen-2018 merged 3 commits intomainfrom
cms-about

Conversation

@wen-2018
Copy link
Copy Markdown
Collaborator

@wen-2018 wen-2018 commented Mar 30, 2026

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

This PR adds a CMS based about us page.

Significant changes and points to review

Issue / Bugzilla link

https://mozilla-hub.atlassian.net/browse/WT-573

Testing

@wen-2018 wen-2018 added the WIP Pull request is still work in progress label Mar 30, 2026
@wen-2018 wen-2018 force-pushed the cms-about branch 3 times, most recently from ea24bb1 to 1145389 Compare April 16, 2026 15:38
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.85%. Comparing base (43a679c) to head (f651865).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...drock/mozorg/fixtures/showcase_gallery_fixtures.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17099      +/-   ##
==========================================
+ Coverage   81.74%   81.85%   +0.10%     
==========================================
  Files         174      175       +1     
  Lines        9347     9409      +62     
==========================================
+ Hits         7641     7702      +61     
- Misses       1706     1707       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wen-2018 wen-2018 marked this pull request as ready for review April 16, 2026 15:59
@wen-2018 wen-2018 requested review from a team as code owners April 16, 2026 15:59
@wen-2018 wen-2018 added Needs Review Awaiting code review and removed WIP Pull request is still work in progress labels Apr 16, 2026
Copy link
Copy Markdown
Contributor

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one small thing before I approve

Rather than add a new page with the slug of about-2026 You can add a new page at about if you wrap the Django view at

path("about/", views.AboutView.as_view(), name="mozorg.about.index"),
in prefer_cms - that'll make the switchover to the new page easier, too.

If you do this, I'll test drive it locally with about as the slug and see if any child pages complain.

Copy link
Copy Markdown
Contributor

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @wen-2018 - works for me, but I also had to add LeadershipPage an allowed subpage_type so that we can swap the StructuralPage at about for this new page when we are ready to go live -- the child pages of the current about will need to be moved.

Happy to do the swapping over once the content for the new page is populated (we'll have to make it with a different slug (about-new) and then swap them over quickly while the CDN catches requests.)

@wen-2018 wen-2018 merged commit 148f236 into main Apr 17, 2026
8 checks passed
@wen-2018 wen-2018 deleted the cms-about branch April 17, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Awaiting code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants