Conversation
ea24bb1 to
1145389
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17099 +/- ##
==========================================
+ Coverage 81.74% 81.85% +0.10%
==========================================
Files 174 175 +1
Lines 9347 9409 +62
==========================================
+ Hits 7641 7702 +61
- Misses 1706 1707 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevejalim
left a comment
There was a problem hiding this comment.
LGTM - one small thing before I approve
Rather than add a new page with the slug of about-2026 You can add a new page at about if you wrap the Django view at
bedrock/bedrock/mozorg/urls.py
Line 24 in 43a679c
prefer_cms - that'll make the switchover to the new page easier, too.
If you do this, I'll test drive it locally with about as the slug and see if any child pages complain.
stevejalim
left a comment
There was a problem hiding this comment.
Thanks for this @wen-2018 - works for me, but I also had to add LeadershipPage an allowed subpage_type so that we can swap the StructuralPage at about for this new page when we are ready to go live -- the child pages of the current about will need to be moved.
Happy to do the swapping over once the content for the new page is populated (we'll have to make it with a different slug (about-new) and then swap them over quickly while the CDN catches requests.)
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.One-line summary
This PR adds a CMS based about us page.
Significant changes and points to review
Issue / Bugzilla link
https://mozilla-hub.atlassian.net/browse/WT-573
Testing