Merged
Conversation
alexgibson
reviewed
Jan 13, 2017
| #. Add the following config settings to your ``.env`` file: | ||
|
|
||
| ``FXA_IFRAME_SRC=https://stomlinson.dev.lcip.org/`` | ||
| ``CSP_EXTRA_FRAME_SRC=https://stomlinson.dev.lcip.org/`` |
Contributor
There was a problem hiding this comment.
Should this and FXA_IFRAME_SRC above actually have single quotes around the URLs?
Contributor
Author
There was a problem hiding this comment.
I don't have any quotes around them in my .env file and it works, so I think it's okay?
alexgibson
approved these changes
Jan 13, 2017
Contributor
alexgibson
left a comment
alexgibson
left a comment
There was a problem hiding this comment.
One question, but otherwise looks good. r+ (optional wc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds bit to the FxA docs to get things working w/CSP.